gh-158213: Don't return a str subclass from PyUnicodeWriter_Finish() - #158214
Merged
Merged
Conversation
…ish() Since pythonGH-157861, every writer uses the read-only optimization of _PyUnicodeWriter_WriteStr(), so the first write of a str subclass instance into an empty writer kept that object as the buffer, and PyUnicodeWriter_Finish() returned it. io.StringIO.getvalue() then returned the written object itself, and the next write re-read it through its __str__() method, which changed the contents and could make read() read past the end of the buffer. Only use the read-only optimization for exact str objects. A subclass is copied into a new buffer, as before pythonGH-157861.
Member
|
Oh, thanks for the Thanks also for added tests, they cover well the change so it LGTM. I merged your fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyUnicodeWriter_WriteStr()now takes the read-only shortcut only for exactstrobjects, so astrsubclass is copied into a new buffer andPyUnicodeWriter_Finish()returns astr. This fixesio.StringIOafter writing astrsubclass.No NEWS entry: this fixes code added in GH-157861, which has not been released yet.
io.StringIOcorrupts its contents after writing astrsubclass #158213