gh-153838: Skip non-regular source files in the heatmap exporter - #153839
Merged
Merged
Conversation
pablogsal
changed the title
pablogsal
added
the
needs backport to 3.15
pablogsal
enabled auto-merge (squash)
October 5, 2026 14:07
pablogsal
approved these changes
Oct 5, 2026
pablogsal
removed
the
needs backport to 3.15
|
GH-158853 is a backport of this pull request to the 3.15 branch. |
pablogsal
added
type-bug
pablogsal
added a commit
that referenced
this pull request
Oct 5, 2026
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Oct 5, 2026
…heatmap exporter (pythonGH-153839) (python#158853)" This reverts commit 48998df.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heatmap exporter can hang or read indefinitely when a sampled filename points to a FIFO or device. Check that the source is a regular file before reading it and use the existing unavailable-source placeholder otherwise.
Tests require generated HTML and verify that missing files, directories, and FIFOs are never opened. Regular-file exports remain covered. There is no size cap, following the review discussion in #153838. The profiling test suite passes.
Closes #153838.