Repository navigation
codeop incomplete-input warning test invokes the compiler outside warning capture #159362
Description
CodeopTests.test_incomplete_warning in Lib/test/test_codeop.py exits warnings.catch_warnings(record=True) before calling the compiler:
with warnings.catch_warnings(record=True) as w:
warnings.simplefilter("always")
compiler("'\\e' + (")
self.assertEqual(w, [])As a result, the empty-list assertion cannot detect warnings emitted by that compilation. Keeping the compiler call inside the capture context restores the intended regression coverage.
Verified on CPython main at 9ed41860b411144dbb6d2e4f53489d432364fd19: a runtime compiler replacement that emits SyntaxWarning is accepted by the original test and rejected by the corrected test. The corrected test_codeop tests pass with the actual compilers on a Windows debug build.
Activity
pythongh-159362: Add NEWS entry for codeop-warning-capture-test
pythongh-159362: Omit NEWS for test-only changes
aisk commentedon Oct 14, 2026
Hi @esadomer, I noticed you've opened a lot of issues (20+) and PRs in a short time, so I suspect they are AI-generated.
Before we spend more time reviewing them, I want to make sure you've actually reviewed and understood these changes yourself, and that you're taking responsibility for them, as required by our AI guidelines.
esadomer commentedon Oct 14, 2026
Hi @aisk, thanks for raising this. I do use AI as an aid, but I review the changes myself and take responsibility for what I submit.
I opened the PRs as drafts because I don't want to take up maintainers' time before I'm confident that I understand the changes and they're ready for review. So far, I've only had time to complete that process for five PRs, which are the ones I've marked ready for review. The others remain drafts.
I'll focus on those five first, then review and refine the remaining drafts as time allows. Thanks for your patience :)
aisk commentedon Oct 14, 2026
Thanks for clarifying! However, it's also better not to open too many issues at once before verified them, since triagers and other contributors may spend time validating and investigating them after they're created.
So please make sure you've confirmed the problem and checked for duplicates before opening a new issue.
picnixz commentedon Oct 14, 2026
Those kind of issues do not require an issue. You could have opened the PR directly.