Conversation
The public now, today, tomorrow, and yesterday helpers already accept datetime.tzinfo objects at runtime. Align their signatures with DateTime.now and cover standard library timezone and ZoneInfo inputs with typed tests. Fixes python-pendulum#783.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #783.
The top-level
now()annotation excludesdatetime.timezoneandzoneinfo.ZoneInfo, even thoughDateTime.now()and the runtime already acceptdatetime.tzinfo. The same mismatch affectstoday(),tomorrow(), andyesterday().This aligns the four public annotations with their runtime behavior, adds typed regression coverage for standard-library UTC and
ZoneInfo("Europe/Paris"), and updates the README and instantiation guide. No runtime behavior changes.Validation on Windows CPython 3.12.7:
PENDULUM_EXTENSIONS=0): 1847 passed, 5 skipped.tests/test_main.py: passed. Before the change it reported four incompatible-argument errors for these helpers.unused-ignoreerror insrc/pendulum/tz/timezone.py:65; reproduced on unchangedmaster.AI assistance: Codex helped investigate, implement, and test this change. I reviewed the resulting diff and test results.