Warn about inconsistent plural forms during extraction - #1364
Open
saltnpepper97 wants to merge 1 commit into
Open
saltnpepper97 wants to merge 1 commit into
saltnpepper97 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When plural messages share the same singular text and context but use different plural text, Babel currently keeps the first plural without a warning.
This change checks the existing catalog entry before adding the incoming message and logs a warning with the source location and both plural forms when they conflict. The first plural and merged source locations are preserved.
Tests cover conflicting
ngettextandnpgettextcalls, conflicts across files, identical plural text, separate contexts, and mixed singular/plural calls.Validation on macOS with Python 3.14.2:
Fixes #1003.