Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #661.
A one-form plural translation is currently checked against the singular source. This rejects valid translations when the singular already contains a named placeholder and the plural introduces another:
The original no-placeholder example in #661 already passes on master, but this variant still fails. Use the plural source for a plural message in a catalog with exactly one plural form. That translation is used for every count, including plural counts.
Regressions cover Chinese, Japanese and Korean, incompatible/unknown placeholders, and the existing singular validation in a two-form catalog. Four new cases fail before the fix.
Validation:
python -m pytest tests/messages/test_checkers.py tests/messages/test_catalog.py -q --tb=short --show-capture=no— 92 passed. Configured pre-commit checks passed for both changed files.AI assistance: Codex investigated the remaining failure, prepared the fix and tests, and ran these automated checks. No independent human review is claimed.