Fix CRLF being counted as two line breaks with preserve_blank_lines - #104
Open
afonsojanu wants to merge 1 commit into
Open
afonsojanu wants to merge 1 commit into
afonsojanu wants to merge 1 commit into
Conversation
When preserve_blank_lines=True, lines were split on the character class [\r\n], which treats a Windows CRLF as two separate line endings instead of one. Every \r\n in the input therefore produced an extra blank line in the output (a single line break could turn into up to four newlines). Split on the line-ending sequence \r\n|\r|\n instead, so CRLF, lone CR, and LF are all treated as one line break each. The preserve_blank_lines=False path already used [\r\n]+ and was not affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103.
preserve_blank_lines=Truesplits the input on the character class[\r\n], which matches each of\rand\nseparately. A Windows-style\r\nline ending is therefore split into two pieces with an empty string between them, and that empty string turns into an extra blank line once the pieces are joined back together with\n.This changes the split to match a full line-ending sequence (
\r\n,\r, or\n) instead of any single character in that class, so CRLF is treated as one line break like it should be. Thepreserve_blank_lines=Falsebranch already used[\r\n]+and doesn't have this problem, so it's untouched.Added a test case covering CRLF and lone-CR input under
preserve_blank_lines=True, since the existing blank-line tests only exercised\n.