Add support for phpX.Y bin name format - #349
Open
MauricioFauth wants to merge 1 commit into
Open
MauricioFauth wants to merge 1 commit into
MauricioFauth wants to merge 1 commit into
Conversation
This makes easier to run configure.php with a versioned PHP executable. Also removes php5* bin names, as PHP 5 is not supported.
Member
|
This is something that bothers me. There is a case where PHP_BINARY does not work? I think that this |
Member
Author
Using the constant I use the option Even if the constant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes easier to run
configure.phpwith a versioned PHP executable. Also removes php5* bin names, as PHP 5 is not supported.For example: