Fix CI lint failure and test supported Python versions - #327
Open
devdavidejesus wants to merge 2 commits into
Open
devdavidejesus wants to merge 2 commits into
devdavidejesus wants to merge 2 commits into
Conversation
MoneyRange() and CheckTransaction() only read coreparams; they never assign to it, so the global statements are not needed. flake8 7.4.1 reports them as F824, which makes the lint step of the CI fail.
Python 3.9 and 3.10 have reached end-of-life; test 3.11 to 3.14 instead. Update actions/checkout and actions/setup-python to v7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326
global coreparamsstatements. Both functions only readcoreparams; the compiled bytecode ofMoneyRange()andCheckTransaction()is identical before and after (checked on CPython 3.13 and 3.14).CI on my fork (CPython 3.11.16, 3.12.14, 3.13.15, 3.14.7; flake8 7.4.1):