Repository navigation
refactor: STATS & RULES' controls shared (5a3b1) - #295
Merged
Merged
Conversation
The controls that edit a stats group, a table and a formula (its name, its text with its mistake and its alternative, INSERT's chips) move out of StatsRulesPage into statsRulesFields, one copy that FORMS lays out and the graph view's node panel will show, so an edit made from the map is the same edit as one made in FORMS. No change to what FORMS does; its tests pass unchanged. The builder test that opens GRAPH gives the lazily loaded map up to five seconds, as a busy run is slow to fetch it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controls that edit a stats group, a table and a formula (its name, its text with its mistake and its alternative, INSERT's chips) move out of StatsRulesPage into statsRulesFields, one copy that FORMS lays out and the graph view's node panel will show, so an edit made from the map is the same edit as one made in FORMS. No change to what FORMS does; its tests pass unchanged.
The builder test that opens GRAPH gives the lazily loaded map up to five seconds, as a busy run is slow to fetch it.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues