Skip to content

refactor: STATS & RULES' controls shared (5a3b1) - #295

Merged
over2take merged 1 commit into
feature/system-builderfrom
sb/5a3b1-shared-fields
Oct 18, 2026
Merged

over2take merged 1 commit into
feature/system-builderfrom
sb/5a3b1-shared-fields

Conversation

@over2take

Copy link
Copy Markdown
Owner

The controls that edit a stats group, a table and a formula (its name, its text with its mistake and its alternative, INSERT's chips) move out of StatsRulesPage into statsRulesFields, one copy that FORMS lays out and the graph view's node panel will show, so an edit made from the map is the same edit as one made in FORMS. No change to what FORMS does; its tests pass unchanged.

The builder test that opens GRAPH gives the lazily loaded map up to five seconds, as a busy run is slow to fetch it.

Summary

Test plan

  • Tested locally
  • Tests pass

Pre-merge checklist

Code quality:

  • Code follows project style
  • No breaking changes (or clearly documented)
  • No console errors or warnings

Version & Release:

  • Version bumped? If releasing to users, update:
    • frontend/package.json version
    • docker-compose.yml APP_VERSION
    • CHANGELOG.md with release notes
  • GitHub Actions will auto-tag Docker images with the new version

Before merging to main:

  • All tests passing
  • PR reviewed and approved
  • Branch is up to date with main
  • No merge conflicts

Related issues

The controls that edit a stats group, a table and a formula (its name,
its text with its mistake and its alternative, INSERT's chips) move out
of StatsRulesPage into statsRulesFields, one copy that FORMS lays out
and the graph view's node panel will show, so an edit made from the map
is the same edit as one made in FORMS. No change to what FORMS does; its
tests pass unchanged.

The builder test that opens GRAPH gives the lazily loaded map up to five
seconds, as a busy run is slow to fetch it.
@over2take
over2take merged commit e67dc08 into feature/system-builder Oct 18, 2026
6 checks passed
@over2take
over2take deleted the sb/5a3b1-shared-fields branch October 18, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant