Repository navigation
fix: a system file can't stop the server - #291
Merged
Merged
Conversation
A formula calling constructor(1) or toString(1) passed every check, since the built-in function table was a plain object, and then threw on each save of a sheet in that system, inside database callbacks where nothing caught it. The table has no prototype now. A buildings kind with such a name made the check throw; it is an ordinary problem now. And a system's recompute never throws out into a save: the sheet keeps its values and the server logs why. New tests fill system files with harmful names at every key and name, nesting and sizes past the caps, and check nothing throws or leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A formula calling constructor(1) or toString(1) passed every check, since the built-in function table was a plain object, and then threw on each save of a sheet in that system, inside database callbacks where nothing caught it. The table has no prototype now. A buildings kind with such a name made the check throw; it is an ordinary problem now. And a system's recompute never throws out into a save: the sheet keeps its values and the server logs why.
New tests fill system files with harmful names at every key and name, nesting and sizes past the caps, and check nothing throws or leaks.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues