Conversation
Pure cargo fmt --all output; no semantic changes. Keeps the workspace rustfmt-clean so `cargo fmt --all -- --check` passes in verification. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
clippy's should_implement_trait fires on the inherent `from_iter` method — implement the real trait instead. Call sites keep working via the prelude. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- #![allow(clippy::too_many_arguments)] — the provision/observe entry points intentionally take flat dispatch-arg lists; the 7-arg heuristic doesn't fit this API surface. - Derive Default for FleetRuntime instead of a manual impl. - `?` operator in role_identity. Mirrors the gate fixes landed on the sibling branch for studio#29. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…bdev#3) Folds the four wontfix-or-fold items from the ADR-1 eight-axis review into docs/adr/agent-lifecycle.md: - Draw the hard-loss Stopping→Stopped edge distinctly from the graceful "state saved" edge, and state in §4/the Stopping row that a mid-drain kill still lands in Stopped (best-effort window, cause distinguishes). - §9 gains a "Lock-in / reversibility" note naming the cheap parts (per-driver projection, attribute vocabularies, new drivers) vs the expensive ones (the 6-state surface, the single-field dispatch predicate, the latching identity_verified invariant). - Record that `Paused` wire naming (peer enum variant vs (running, accepting_work=false) projection) is deferred to the RuntimeDriver-contract ADR — this ADR fixes semantics, not identifiers. - Tighten the `superseded` phrasing to instance-level scope: the instance keeps every normal edge and is never pinned in Paused. New crates/agent-lifecycle/tests/adr_review_followups.rs pins the four bits of wording so a later edit can't silently un-fold them. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3
Summary
Folds the four wontfix-or-fold items from the ADR-1 eight-axis review into
docs/adr/agent-lifecycle.md:Stopping → Stopped : hard loss mid-drainedge next to the gracefulstate savedone; §4 and the Stopping row state that a mid-drain kill still lands inStopped(best-effort window, deathcausedistinguishes the edges).identity_verifiedinvariant).State.Paused— the wire-naming/enum question (peerPausedvariant vs(running, accepting_work=false)projection) is recorded as deferred to the RuntimeDriver-contract ADR (ADR-2); this ADR fixes semantics, not identifiers.supersededsentence — tightened to instance-level scope:accepting_work=falseon that instance ⇒ Paused, still finishes in-flight work, keeps every normal edge, and never pins the instance in place.Adds
crates/agent-lifecycle/tests/adr_review_followups.rs— a doc-guard test pinning the four bits of wording so a later edit can't silently un-fold them.Note on the diff size: most of the diff is a
cargo fmt --allworkspace normalization plus threeclippy -D warningsfixes (FromIteratorforSkillsLibrary, derivedDefaultforFleetRuntime,?inrole_identity, crate-leveltoo_many_argumentsallow) — required because the pinned base is not fmt/clippy-clean under the current stable toolchain. Same approach as the already-verified branch for #29. Supersedes the earlier unverified attempt at #162 (same issue, diverged branch).Test plan
cargo fmt --all -- --check— exit 0cargo test --workspace— exit 0 (incl. 4 new doc-guard tests; they fail with 101 on the base doc)cargo clippy --workspace --all-targets -- -D warnings— exit 0Generated with Devin