Repository navigation
Hide hero benchmark graphs the API no longer returns - #3392
Merged
Merged
Conversation
The hero Benchmarks page builds a fixed list of eight graphs, two of which read lhten and stuns_per_min. Those two benchmarks were commented out in core in 2023 (odota/core@26bae0b, when benchmarks moved to unparsed matches), so the response has not carried them since. mapData leaves Value as false for a missing key, which renders a titled graph with an empty plot rather than nothing at all. Filter out graphs with no numeric value at any percentile instead of deleting the two entries, so they come back on their own if core ever serves them again.
howardchung
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hero Benchmarks page renders eight graphs from a fixed list. Two of them read
lhtenandstuns_per_min, which were commented out in core in odota/core@26bae0b ("do unparsed benchmarks and simplify insert stack", Nov 2023) when benchmarks moved to unparsed matches./api/benchmarks?hero_id=1hasn't returned them since:mapDataleavesValueasfalsewhen the key is missing, so those two render as a titled graph with a percentile axis and an empty plot. It's on every hero page right now:Filtering on "has a numeric value at some percentile" rather than deleting the two entries, so they come back on their own if core serves them again, and so the page doesn't do this for the next benchmark that goes away.
Checked against a local build of this branch pointed at the live API: 8 graphs before, 6 after, and the six left are the ones with axes. A legitimately all-zero series still renders,
hero_healing_per_minin the screenshot above for instance.Related to #2801, which reports the stuns benchmark missing for Pangolier. It's missing for everyone.