Conversation
chaitu236
left a comment
chaitu236
left a comment
There was a problem hiding this comment.
Changes look fine.
Just a suggestion on commit header
[ARM][ni-slsc-12001.dts] Add 802.3 compatibility string
This is more standard I think ARM: dts: ni-slsc-12001: Add 802.3 compatibility string
Also, can you add testing details to PR description.
kkang-NI
changed the title
As of 801a8ef (of: phy: Only register a phy device for phys), the OF MDIO code checks for either some 802.3 compatible strings or no compatible strings at all. This resulted in the kernel thinking that the PHYs in the NI DTs (all of which call out a compatibility property) were something other than PHYs. other related commits: b6e051a, 984b01d Signed-off-by: Kae Woei Kang <kae.woei.kang@emerson.com>
3d41c31 to
3c911a6
Compare
I've updated the commit header. I've not performed any testing on kernel 6.18 yet, as the DTS and defconfig carried over from kernel 4.14 still require some modifications before the kernel can be built successfully. However, this particular change, which was cherry-picked from kernel 4.14, has been tested and verified to work successfully on kernel 4.14. |
3 participants
As of 801a8ef (of: phy: Only register a phy device for phys), the OF MDIO code checks for either some 802.3 compatible strings or no compatible strings at all. This resulted in the kernel thinking that the PHYs in the NI DTs (all of which call out a compatibility property) were something other than PHYs.
other related commits: b6e051a.
WI: AB#3978052
Validation results:
Cherry picked from nilrt/master/4.14: commit 984b01d
testing was done in kernel 4.14 which the SLSC chassis is detected in NI-MAX and NI-Hardware Manager.