Repository navigation
Fix public shared file download - #885
Merged
Merged
Conversation
binsky08
commented
Sep 19, 2026
binsky08
commented
Collaborator
- fix public shared file download
- refactor getFile method in ShareController to enhance file access control and prevent probing for existing credential or file guids even if not currently shared (based on the kind of response)
- (nice finding while checking if the public page attribute fix works xD)
…getFile method in ShareController Signed-off-by: binsky <timo@binsky.org>
…trol and prevent probing for existing credential or file guids even if not currently shared (based on the kind of response) Signed-off-by: binsky <timo@binsky.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.