Repository navigation
perf: count form submissions in bulk for the forms list - #3734
Merged
Merged
Conversation
Koc
added
php
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Koc
force-pushed
the
feature/forms-list-bulk-submission-count
branch
from
October 7, 2026 21:13
df0455e to
3f8acc6
Compare
Koc
marked this pull request as ready for review
October 7, 2026 21:15
Chartman123
force-pushed
the
feature/forms-list-bulk-submission-count
branch
from
October 11, 2026 20:59
3f8acc6 to
986538a
Compare
Collaborator
|
/backport to stable5.4 |
Chartman123
approved these changes
Oct 11, 2026
Chartman123
reviewed
Oct 11, 2026
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/forms-list-bulk-submission-count
branch
from
October 11, 2026 22:06
986538a to
1334283
Compare
Koc
enabled auto-merge (squash)
October 11, 2026 22:07
Chartman123
approved these changes
Oct 11, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable5.4
git pull origin stable5.4
# Create the new backport branch
git checkout -b backport/3734/stable5.4
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1334283d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3734/stable5.4Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Collaborator
|
@Koc could you please look into the failed backport and do it manually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /ocs/v2.php/apps/forms/api/v3/forms endpoint ran one countSubmissions() query per listed form. Add
SubmissionMapper::countSubmissionsByForms() which counts submissions for many forms with a single WHERE form_id IN (...) GROUP BY form_id query, served by the forms_submissions_form_user index, and let FormsService::getPartialFormArrays() fetch the counts for the whole list with at most two queries: one for forms where the user may see all results and one for forms where only their own submissions count.
Assisted-by: Devin:SWE-2
before
after
🤖 AI (if applicable)