test: take the repo root from pytest so the ADR check can run from a fetched copy - #119
Merged
Merged
Conversation
This was referenced Sep 27, 2026
Merged
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
`test_adr_citations.py` computed the repo root as `Path(file).parent.parent`. It now takes `pytestconfig.rootpath`.
Why
Pilot for replacing the 25 byte-identical copies of this test across the org with a fetch of this file from `main` (first consumer: eof-fixer). A fetched copy lives in a temp directory, so `file` points nowhere useful; `rootpath` is the repo pytest is run for.
For this repo nothing changes: `testpaths = ["tests"]` and the `pyproject.toml` ini section make rootpath the repo root. A consumer runs it as `pytest --rootdir=. `, which gives the same rootpath without pulling in the consumer's `addopts`.
Verified