You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When enable_dns_rebinding_protection=True, TransportSecurityMiddleware checks Host and Origin together. It can't do one without the other, and an empty allowed_origins means any request that carries an Origin header is rejected. MCPServer and lowlevel.Server also turn this on by default for localhost binds, with a localhost-only allowed_origins.
This blocks browser-based MCP clients such as extensions. A Chrome extension sends Origin: chrome-extension://<id>. The same request with the same credentials gets 200 without an Origin header and 403 with one. The only fix is for every server operator to allowlist each client by hand.
The Origin check doesn't add rebinding protection. The DNS-rebinding advisory (GHSA-9h52-p55h-vw2f) is closed by the Host check. An Origin check is a CSRF control, and it only matters when the server accepts credentials the browser sends automatically, such as cookies. The full threat model is in modelcontextprotocol/modelcontextprotocol#3370.
The Go SDK made this change already. Host protection on loopback is on by default. Origin protection was on by default in v1.4.1 through v1.5.0 and has been off since v1.6.0. The setting that could restore it was removed in v1.8.0.
Proposal:
Validate Origin only when allowed_origins is non-empty. An empty list means no Origin check, not reject-all.
Drop the default localhost allowed_origins in MCPServer and lowlevel.Server.
Host validation and its defaults are unchanged. When the Origin check is on, Origin: null is still rejected.
Update docs/run/deploy.md to describe allowed_origins as the CSRF control and allowed_hosts as the DNS-rebinding control.
This doesn't reopen CSRF on unauthenticated localhost servers. The middleware already returns 400 for any POST whose Content-Type isn't application/json, and a cross-site JSON POST forces a CORS preflight. I'd add a test that pins this.
Compatibility: there are two behaviour changes, and I'd like a maintainer's view on whether a 2.x minor release is OK for them.
Localhost servers using the defaults would no longer reject cross-origin requests that pass the Host and Content-Type checks.
Anyone who sets allowed_hosts without allowed_origins would no longer reject every request that carries an Origin header.
In both cases, setting allowed_origins explicitly restores today's behaviour.
Further proposals
Scheme wildcards in allowed_origins. Once Origin validation is opt-in, an operator who turns it on still has to list every browser-extension client by hand. That's impossible for Firefox, whose moz-extension://<uuid> origin differs on every install. Proposal:
An entry of the form "<scheme>://*" matches any Origin with that scheme, for example "chrome-extension://*" or "moz-extension://*".
Exact entries and the existing :* port wildcard keep working as today.
"http://*" and "https://*" raise a ValueError, because they would allow every website. Leaving allowed_origins empty already does that.
A machine-readable reason in the rejection body. Today a Host rejection is 421 Invalid Host header and an Origin rejection is 403 Invalid Origin header, both as plain text. A client can't reliably tell these from an auth failure, so it can't tell the user that signing in again won't help. Proposal: keep the status codes, but return a JSON-RPC error body whose data.reason carries a stable code:
The reason values would match the ones the TypeScript SDK already computes internally (missing_host, invalid_host, invalid_origin_header, invalid_origin), so clients can handle both SDKs the same way.
Description
When
enable_dns_rebinding_protection=True,TransportSecurityMiddlewarechecks Host and Origin together. It can't do one without the other, and an emptyallowed_originsmeans any request that carries anOriginheader is rejected.MCPServerandlowlevel.Serveralso turn this on by default for localhost binds, with a localhost-onlyallowed_origins.This blocks browser-based MCP clients such as extensions. A Chrome extension sends
Origin: chrome-extension://<id>. The same request with the same credentials gets 200 without anOriginheader and 403 with one. The only fix is for every server operator to allowlist each client by hand.The Origin check doesn't add rebinding protection. The DNS-rebinding advisory (GHSA-9h52-p55h-vw2f) is closed by the Host check. An Origin check is a CSRF control, and it only matters when the server accepts credentials the browser sends automatically, such as cookies. The full threat model is in modelcontextprotocol/modelcontextprotocol#3370.
The Go SDK made this change already. Host protection on loopback is on by default. Origin protection was on by default in v1.4.1 through v1.5.0 and has been off since v1.6.0. The setting that could restore it was removed in v1.8.0.
Proposal:
Originonly whenallowed_originsis non-empty. An empty list means no Origin check, not reject-all.allowed_originsinMCPServerandlowlevel.Server.Origin: nullis still rejected.docs/run/deploy.mdto describeallowed_originsas the CSRF control andallowed_hostsas the DNS-rebinding control.This doesn't reopen CSRF on unauthenticated localhost servers. The middleware already returns 400 for any POST whose Content-Type isn't
application/json, and a cross-site JSON POST forces a CORS preflight. I'd add a test that pins this.Compatibility: there are two behaviour changes, and I'd like a maintainer's view on whether a 2.x minor release is OK for them.
allowed_hostswithoutallowed_originswould no longer reject every request that carries anOriginheader.In both cases, setting
allowed_originsexplicitly restores today's behaviour.Further proposals
Scheme wildcards in
allowed_origins. Once Origin validation is opt-in, an operator who turns it on still has to list every browser-extension client by hand. That's impossible for Firefox, whosemoz-extension://<uuid>origin differs on every install. Proposal:"<scheme>://*"matches anyOriginwith that scheme, for example"chrome-extension://*"or"moz-extension://*".:*port wildcard keep working as today."http://*"and"https://*"raise aValueError, because they would allow every website. Leavingallowed_originsempty already does that.:*suffix bug), since it touches the same matcher.A machine-readable reason in the rejection body. Today a Host rejection is
421 Invalid Host headerand an Origin rejection is403 Invalid Origin header, both as plain text. A client can't reliably tell these from an auth failure, so it can't tell the user that signing in again won't help. Proposal: keep the status codes, but return a JSON-RPC error body whosedata.reasoncarries a stable code:{ "jsonrpc": "2.0", "error": { "code": -32000, "message": "Invalid Origin header", "data": { "reason": "invalid_origin" } }, "id": null }The reason values would match the ones the TypeScript SDK already computes internally (
missing_host,invalid_host,invalid_origin_header,invalid_origin), so clients can handle both SDKs the same way.Disclosure: drafted with Claude Code;