Add getJSDocCommentsAndTags back with functionality of 6.0 - #64455
Open
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 2 commits into
Open
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 2 commits into
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 2 commits into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Titian Cernicova-Dragomir (dragomirtitian)
September 25, 2026 21:59
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Formatting, public documentation, and individual-tag test coverage need correction.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Restores the public getJSDocCommentsAndTags AST API with TypeScript 6-compatible ancestor traversal and comment preservation.
Changes:
- Returns whole JSDoc nodes when appropriate while preserving
getJSDocTags. - Adds async and generated sync API tests.
| File | Description |
|---|---|
packages/typescript/src/ast/jsdoc.ts |
Implements and exports the restored API. |
packages/typescript/test/async/api.test.ts |
Adds API behavior tests. |
packages/typescript/test/sync/api.test.ts |
Adds generated synchronous tests. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| assert.deepEqual(getJSDocTags(answer), []); | ||
| }); | ||
|
|
||
| test("returns individual tags when the host node does not own all of them", async () => { |
Comment on lines
+103
to
112
| let onlyOwnTags = jsDoc.tags?.every(t => ownsJSDocTag(hostNode, t)) ?? true | ||
| if(!onlyOwnTags && jsDoc.tags) { | ||
| for (const tag of jsDoc.tags) { | ||
| if (ownsJSDocTag(hostNode, tag)) { | ||
| result.push(tag); | ||
| } | ||
| } | ||
| } else { | ||
| result.push(jsDoc) | ||
| } |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64394