Replace vscode l10n-dev with local localization generator - #64454
Open
Jake Bailey (jakebailey) wants to merge 3 commits into
Open
Jake Bailey (jakebailey) wants to merge 3 commits into
Jake Bailey (jakebailey) wants to merge 3 commits into
Conversation
Jake Bailey (jakebailey)
requested review from
Wesley Wigham (weswigham)
and
a balanced review from Copilot
September 25, 2026 21:56
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 25, 2026 21:57
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Path-depth sorting produces platform-dependent bundle ordering on Windows.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Replaces @vscode/l10n-dev with lightweight repository tooling for extension localization.
Changes:
- Adds static string extraction and pseudo-localization.
- Adds generator tests and cache tracking.
- Removes the dependency and its transitive packages.
| File | Description |
|---|---|
tools/scripts/gen/extensionLocalization.mts |
Implements localization generation. |
tools/scripts/gen/extensionLocalization.test.mts |
Tests extraction and pseudo-localization. |
packages/vscode-typescript/package.json |
Uses the local generator. |
package-lock.json |
Removes obsolete dependencies. |
Herebyfile.mjs |
Tracks generator changes in caches. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
The extension only needs extraction of literal messages and pseudo- localization, but @vscode/l10n-dev adds a large dependency tree. Generate these resources with existing tooling and reject unsupported VS Code import styles instead of silently omitting strings.
Jake Bailey (jakebailey)
force-pushed
the
lightweight-l10n
branch
from
September 25, 2026 22:18
bc6ff27 to
1381d88
Compare
Source-file order does not affect localization lookup, and sorting it requires platform-sensitive path handling. Order messages by their keys instead for deterministic output.
SourceFile.parseDiagnostics is not part of the public TypeScript API, so the generator fails type-checking. The extension build reports syntax errors without depending on this internal field.
Jake Bailey (jakebailey)
enabled auto-merge
September 25, 2026 22:46
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension only needs string extraction and pseudo-localization, but
@vscode/l10n-devpulls in a large dependency tree. Generate these resources with existing repository tooling instead, which is close enough for us, I think!