[MOO-2490] : Barcode scanner fixes 11 6 x - #666
Open
saurabhchavan1711 wants to merge 3 commits into
Open
saurabhchavan1711 wants to merge 3 commits into
saurabhchavan1711 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
This PR fixes issue of barcodes with patterned background not getting scanned correctly on Android. The issue occurs because the cameraX from react native vision camera library sends default scanned images to ML kit algorithm which has low resolution (640x480) , patched it in NT with higher resolution 1920 x 1440. so the internal algorithm gets higher resolution image to process. Added scan delay property to the barcode scanner widget so user will get time to adjust the qr code in the mask because with this higher resolution , the barcode will scanned quickly which sometimes is not expected , so customers can adjust this parameter. Also robust the Android scanning logic with checking if consecutive 3 scanned frames has same value or not.
What should be covered while testing?
Test the attached barcode in the jira ticket that customer shared. Also test few different online generated QRs on both IOS and Android