0.15.1: a vcpkg installation waits for another one of the same root - #33
Merged
Merged
Conversation
…--x-wait-for-lock) instead of failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under 0.15.0, GalTranslPP (Windows) failed in
mcpp build -p GPPCLI. Two workspace members install one vcpkg root, and their actions ran at once:0.13.0 and 0.14.0 serialised the two installations with their own lock, inside
mcpp-deps. Since 0.15.0 the action is vcpkg itself, and vcpkg waits for its root lock only when asked to. The action now passes--x-wait-for-lock.Measured locally with two concurrent
vcpkg installruns on one root: with the flag, both exit 0 (one reports "waiting to take filesystem lock"); without it, one exits 1. Thevcpkg-workspacecriterion now also requires the flag in both members' plans. Local runs of vcpkg-consumer and vcpkg-workspace pass. The docs statement that the lock alone serialised the installations is corrected.