Repository navigation
Deepen mdo C6: retire divergent test mirror and dead pub surface - #48
Merged
Merged
Conversation
C6 / Beads mdo-6w5.2 (epic mdo-6w5, PR order 2 of 6; stacked on the C1
branch).
- tests/cli.rs re-implemented temp_output_for as temp_output_for_test and
had already lost stem sanitization (diverged from production). The four
call sites now call mdo_cli::temp_output_for directly, so tests compute
the same per-source private paths production does, sanitization included.
The mirror is deleted, along with the Hash/Hasher imports it alone needed.
- The one-line derive_output alias had a single caller; main.rs now calls
the real target, input.with_extension("html"), and lib no longer exposes
the alias.
- SETUP_SAMPLE_FILE_NAME / SETUP_SAMPLE_MARKDOWN had zero external callers;
both are now private. (Windows SetupSample? not referenced: mdo-setup and
mdo-open never touch them.)
- wrapper.rs's own empty_path_dir duplication is intentionally untouched:
recorded in the issue as having an honest reason.
Gates: fmt --check, clippy -D warnings, cargo test --all-targets
--all-features --locked (90 tests) all green, including the Linux --open
tests that exercise the corrected temp-output path contract.
Beads-Ref: mdo-6w5.2
Agent-Signature: kilo-kilo-auto-efficient on behalf of matt
The import was only used in #[cfg(target_os = linux)] tests but was unconditional, causing clippy -D warnings to fail on macOS/Windows with unused_imports. This is a follow-up to Beads mdo-6w5.2 (C6). Agent-Signature: kilo-kilo-auto-efficient on behalf of matt
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by efficient · Input: 68K · Output: 8.3K · Cached: 318.7K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C6: Retire the divergent test mirror and dead public surface
Beads mdo-6w5.2 · parent epic mdo-6w5 (PR order 2 of 6; stacked on the C1 branch)
What
Gates
fmt --check ✓ · clippy -D warnings ✓ · `cargo test --all-targets --all-features --locked` ✓ (90 tests, including the Linux `--open` suite that now exercises the real path contract)
Recorded byte-identity work from C1 is preserved: no CLI-visible strings changed in this PR.
Signed: kilo-kilo-auto-efficient on behalf of matt (Beads mdo-6w5.2)