Repository navigation
Conversation
cogl-gtype-private.h is listed in cogl_nonintrospected_headers, so it gets installed among the public headers, but it can't be used from outside: it includes cogl-config.h and cogl-object-private.h, which are not installed, so any program including it fails to build. It only holds the COGL_GTYPE_DEFINE_* macros used by the cogl sources to define their GTypes, none of the public headers uses them, and nothing outside cogl/ includes it. Drop it from the installed header list. It stays in cogl_sources, so the library build is unchanged, and the GIR is not affected either, being generated from cogl_introspected_headers. The header comes from mutter, which kept installing it the same way until it went away with the port of cogl from CoglObject to GObject. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cogl/cogl/cogl-gtype-private.his listed incogl_nonintrospected_headers, so it gets installed in/usr/include/muffin/cogl/cogl/together with the public headers, but it can't be used from outside:cogl-config.handcogl-object-private.h, which are not installed, so any program including it fails to buildCOGL_GTYPE_DEFINE_*macros the cogl sources use to define their GTypes; none of the installed headers uses themcogl/includes itThis PR drops it from the installed header list only. The file stays in
cogl_sources, so the library build is unchanged, and the GIR is not affected either, since it is generated fromcogl_introspected_headers.The header comes from mutter, which kept installing it the same way (3.36 to 44) until the file went away with the port of cogl from CoglObject to GObject (mutter commit 2c4968fb4).