Repository navigation
build: Drop the unused dbus-1 dependency - #868
Merged
mtwebster merged 1 commit intoOct 3, 2026
Merged
Conversation
meson.build looks up dependency('dbus-1') and stores it in dbus_dep, but
the variable is never used: no target lists it in its dependencies, and
nothing in the code uses libdbus (all D-Bus communication goes through
GDBus). The lookup came in with the rebase onto mutter 3.36 (commit
8599127) and only makes the build fail when the libdbus development
files are missing, so distributions have to build-depend on them for
nothing.
Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meson.buildlooks updependency('dbus-1')and stores it indbus_dep, but the variable is never used:dbus_depin its dependencies, in anymeson.build<dbus/...>include, nodbus_*()call, noDBusConnection/DBusMessage/DBusError; all the D-Bus communication goes through GDBusThe lookup came in with the rebase onto mutter 3.36 (8599127) and its only effect is making the configure step fail when the libdbus development files are missing, so packagers have to build-depend on them (
libdbus-1-devon Debian/Ubuntu) for nothing. Today this goes unnoticed only because libdbus-1-dev happens to be pulled in transitively by other build dependencies (e.g. libatspi2.0-dev).