network applet: merge the WireGuard and VPN sections, label each row's kind

[IvanTheGeek]

What changes

• WireGuard connections move into "VPN Connections"; NMDeviceWIREGUARD and its icon override go.
• Each row shows its kind (WireGuard, OpenVPN, PPTP...) in the row's status column.

User-visible changes

• One uncapped list holds both kinds, most recent first; the WIREGUARD heading goes.
• VPN-plugin rows become switches: the menu stays open on click, the dot and bold style go, the switch flips before NM confirms.
• The title switch covers both kinds: off disconnects every tunnel, on starts the most recently used one, possibly WireGuard.
• WireGuard follows the Show "wired with a padlock" or "wireless with a padlock" icons when a VPN is connected #12142 icon path: Wi-Fi bars with a padlock when Wi-Fi is the main connection, "Connected to the VPN" / "Connecting to the VPN..." tooltips, plain bars while disconnecting.
• With tunnels in mixed states, the first one NM lists sets the icon, as two VPN plugins already do.
• WireGuard rows follow renames.
• Three WIREGUARD strings become unused; none are added ("WireGuard" reuses the existing msgid).

Testing without special hardware
A WireGuard profile with no peer activates locally:

nmcli connection add type wireguard con-name wg-test ifname wg-test autoconnect no ipv4.method manual ipv4.addresses 192.0.2.10/32 ipv4.never-default yes ipv6.method disabled wireguard.private-key "$(wg genkey)"

An OpenVPN profile (network-manager-openvpn) pointing at 192.0.2.1 stays connecting until NM's VPN timeout (about 60 s).

Overlaps #13767 (both edit NMDeviceVPN._createSection); whichever lands second needs a rebase. Thanks @wocisjr: #13986 proposed the shared icon path.

Tested on: Cinnamon 6.6.9 (Mint 22.3), with this applet.js as a user-dir override, not a master build: three WireGuard tunnels up at once, OpenVPN rows, row toggles, deleting and renaming profiles, and the OpenVPN password dialog (it takes focus; Cancel turns the row off).

AI assistance: written with help from Claude Opus 5.5 (Anthropic); I reviewed it and tested it on my own machine.

[github-actions]

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.

---

Found 3 potential issue(s):

⚠️ WARNING

⚠️ lang_bind

files/usr/share/cinnamon/applets/network@cinnamon.org/applet.js:935

this._speedChangedId = this.device.connect('notify::speed', Lang.bind(this, function() {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

files/usr/share/cinnamon/applets/network@cinnamon.org/applet.js:1275

obj.item.connect('toggled', Lang.bind(this, function(item, state) {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

files/usr/share/cinnamon/applets/network@cinnamon.org/applet.js:2235

this._watchedApId = ap.connect('notify::strength', Lang.bind(this, function() {

Lang.bind() is deprecated. Use arrow functions (() => {}) or Function.prototype.bind() instead.

---

Automated pattern check.

[IvanTheGeek]

The best-practices scanner findings above are addressed — all of the flagged Lang.bind() uses were in code this PR adds, and they are now arrow functions (which capture this the same way). No new Lang.bind() is introduced; the count in this file actually goes down versus master.

The scanner comment is stale rather than wrong: the workflow re-run is sitting in action_required, since runs from a first-time contributor need maintainer approval. It should clear once someone approves the run.

[mtwebster]

Hi, I merged 13911 -

I'd be fine with merging the sections and adding labels.

I think the additional options here are overkill - the percentage strength is enough.

Wherever you take this, though, I'd prefer smaller PRs - something like this (even though you admitted you didn't expect this to be merged as-is) - is difficult to review, especially since some of it can depend on things the reviewer has no access to for testing. Small bits are easier to look at objectively.

[IvanTheGeek]

Thanks for merging #13911.

Plan: I'll cut this PR down to merging the sections plus a label on each row showing its type (WireGuard, OpenVPN, …), rebuilt on current master. The settings, the band/width/security text and the panel-icon changes go. Two small fixes follow as separate PRs: WPA3/OWE classification (#13912 item 5) and a second splice() bug in the Wi-Fi code.

Sometimes a visual is helpful. Below is what I am running currently with all options turned on. The alignment is still an issue I can not get Claude to get quite right. This is what I will keep running on my box, but finding these issues seemed good to upstream as it was rather broken for my usages before.

(Drafted with help from Claude Opus 5.5.)