Repository navigation
refactor(pi): remove the unused queue and pending approval reads - #2
Merged
Merged
Conversation
Nothing in src called workspace.queue() or workspace.pendingApprovals(). Only their own test did. The session view gets approvals and queued messages from the bootstrap snapshot and live frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
workspace.queue()andworkspace.pendingApprovals()had no callers insrc. Only their own test used them. The session view already gets approvals and queued messages from the bootstrap snapshot and live frames. This removes both reads, their schemas, the matching fixture endpoints, and the fixture's queue list, which was never filled.A coverage audit of the suite found this. The other test files that look redundant by line coverage were kept. Mutation checks showed they are the only tests that guard config precedence, error redaction, token renewal, replay and revocation.
Verification
bun run checkon Bun 1.4.2: format, lint, typecheck and build pass. 121 tests pass and 0 fail.