Repository navigation
fix: bump nanoid to ^5.1.16 and vitest to ^4.1.11 (dependency vulnerabilities) - #40
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…cy vulnerabilities Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…-batch/2026-09-28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency vulnerability fixes (automated)
Generated by the Devin Dependency Security Vuln Fix automation run on 2026-10-12 (first opened 2026-09-28).
Change type: Major version bump(s), manifest/lockfile only.
Warning
We're not just looking for a review like a normal PR. Security can offer this fix as a recommendation, but doesn't have the tooling or domain knowledge to safely verify changes like this end-to-end for each repo. Please review, test, and own deployment before merging. For more information: https://launchdarkly.atlassian.net/wiki/spaces/SEC/pages/5360943572/Dependency+Vulnerability+Remediation+with+Devin.
Findings addressed
packages/web-extension)Notes for reviewers:
/yarn.lockis gitignored and the lockfile is owned bylaunchdarkly/observability-sdk), so this PR only changes manifests. A fresh install resolves nanoid 5.1.16 and vitest 4.1.11.vitestays on^6.4.2, since vitest 4.1.11 supports vite 6, 7 and 8.web-extensiononly uses the namednanoidexport in ESM/Vite code, and the extension builds.nanoidline. That PR sets^5.1.11, which leaves the manifest floor inside alert #95's vulnerable range (< 5.1.16). Whichever PR merges second needs a trivial conflict fix.^4.1.8, which is still inside the< 4.1.11vulnerable range, and it also bumps vite to 8.vitest.workspace.tsusesdefineWorkspace, which vitest 4 removed. No script references the file, because each package runs its ownvitest.config.tsvia turbo, so it was left untouched.main(fix(record): resync replaces grown sheets instead of re-sending the tail #42, stylesheet resync fix). No new findings for this group.Deferred / excluded findings
packages/rrweb-player) ^4.2.14 → 5.55.7, Medium, 234d (Dependabot #52–#55, #75, #76; GHSA-crpf-4hrx-3jrp, GHSA-f7gr-6p89-r883, GHSA-m56q-vw4c-c2cp, GHSA-phwv-c562-gvmh, GHSA-pr6f-5x2q-rwfp, GHSA-rcqx-6q8c-2c42). Fully fixed by Dependabot chore(deps): bump the npm_and_yarn group across 2 directories with 2 updates #32 (^5.56.3).packages/web-extension, viareact-router-dom) 6.30.6 → 7.18.4, Medium, Wiz only (CVE-2026-53666, CVE-2026-53669). See fix: bump react-router-dom to ^7.18.0 in web-extension (dependency vulnerabilities) #41.Verification
Re-checked on 2026-10-12 after merging
main:yarn installresolves nanoid 5.1.16 and vitest 4.1.11. The only failure ispackages/rrvideo's Playwright browser postinstall, which can't reach the Playwright CDN from the automation sandbox. This happens onmaintoo.rrweband its workspace dependencies build. The fullyarn build:allpassed 22/22 on 2026-10-05.mainadded in fix(record): resync replaces grown sheets instead of re-sending the tail #42 (packages/rrweb/test/record/stylesheet-resync.test.ts) passes 9/9 on vitest 4.1.11. The full suite runs in CI (Tests,WebKit (Safari engine) tests).yarn linthad no new errors on 2026-10-05. The only errors are the same 3rrweb-player.svelteparser errors as onmain. CI ESLint runs on this head.Link to Devin session: https://app.devin.ai/sessions/68b2679b5727400b96785aa77f9ca237
Open in Devin Desktop: https://app.devin.ai/desktop/session/68b2679b5727400b96785aa77f9ca237?variant=devin