docs(readme): skills.sh badge, and the Socket badge that stopped loading - #1099
Merged
Merged
Conversation
socket.dev/api/badge now sits behind a Cloudflare challenge, so GitHub's image proxy gets a 403 interstitial instead of an SVG and the badge shows broken for every visitor. Socket serves badges from badge.socket.dev; READMEs already on that host get a 200 through the same proxy.
kucherenko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes to the README's badge row, in one PR because they sit on neighbouring lines.
The Socket badge was broken
It pointed at
socket.dev/api/badge/npm/package/jscpd, and that host now sits behind a Cloudflare bot challenge. GitHub loads README images through its camo proxy, the proxy gets a 403 "Just a moment…" page instead of an SVG, and the badge renders as a broken image for everyone. Every other badge in the row goes through the same proxy with a 200. It is not specific to jscpd — the old URL returns the same challenge forreact,lodashandexpress.Socket serves badges from
badge.socket.devnow, and the badge points there, with/latestso it follows the current release. Other projects hit the same thing and moved over.skills.sh installs
A badge for the agent skills, next to npm downloads since both count how many people use jscpd. It shows the install count skills.sh keeps for
kucherenko/jscpdand links to the repository's page there, which lists the three skills.Checked through GitHub itself
Rendered this branch's README with the GitHub API and fetched each image through the camo URL GitHub generated for it:
image/svg+xml, the badge readsSocket: 99image/svg+xml, the badge readsSkills: 4.8KFrom a plain
curlon some networksbadge.socket.devstill answers with the challenge; what matters for the README is what GitHub's proxy gets, and that is the SVG.This change is