Repository navigation
fix: コンテスト表にページネーションを追加し、ADTタブのフリーズを防ぐ - #1567
Open
Takagi-Masao wants to merge 2 commits into
Open
Takagi-Masao wants to merge 2 commits into
Takagi-Masao wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADTタブを開くとブラウザが長時間応答しなくなり、
RESULT_CODE_HUNGが発生する問題を修正します。コンテスト表の9カテゴリにページネーションを適用し、Listページと同じ操作・見た目に統一します。Fixes #1558
原因
ADTでは数千件のコンテストと大量の問題セルを一度に描画していました。難易度表示に使う大量のTooltipが、マウント時に文字列セレクターでDOMを検索するため、メインスレッドが長時間ブロックされます。
adt_topの非表示だけでは解消できません。変更内容
ListPaginationPanelを再利用し、ページ番号ボタンと表示件数セレクターをListページと同じスタイルに統一します。新しいCSSや依存パッケージは追加しません。確認
なお、単独の
tsc --noEmitには既存のTypeScriptと依存パッケージの型定義の不整合があります。上記の検証結果には単独の型チェックの成功は含めていません。