Repository navigation
Drop the Lakehouse alpha badge and disable the link without 2FA - #260
Merged
Merged
Conversation
The hub rejects any log in session whose token mfa status is not "Used" (BERDL_JupyterHub berdlhub/auth/kb_jupyterhub_auth.py), so a BERDL_USER who logged in without a second factor followed the sidebar link only to land on the hub's MFA-required page. For those sessions the Lakehouse item now renders greyed and unlinked, with a tooltip saying to log in again with ORCID using 2FA. The alpha badge is removed from the item.
dauglyon
force-pushed
the
lakehouse-nav-mfa-gate
branch
from
October 12, 2026 16:48
ef72c77 to
21551e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
alphabadge from the Lakehouse sidebar item.BERDL_USERwhose log in session has anmfastatus other thanUsed, the Lakehouse item renders greyed and unlinked, with a MUI tooltip: "The Lakehouse requires two-factor authentication. Log out, then log in with ORCID using 2FA."Why
The hub rejects any session whose token
mfais notUsed(berdlhub/auth/kb_jupyterhub_auth.pyin BERDL_JupyterHub) and sends the user to its MFA-required page. The sidebar link led those users there with no warning.Notes
NavItemgains an optionaldisabledReasonprop; the Lakehouse item is its only caller.spanwithrole="link"andaria-disabled="true", so the tooltip opens on keyboard focus as well as hover.BERDL_USERstill see no Lakehouse item.Testing
New
src/features/layout/LeftNavBar.test.tsxcovers: item absent without the role; linked and badge-free withmfa: Used; disabled forNotUsedandUnknown.