Skip to content

fix(agda): resolve the two unsolved metas in EchoHaplotypeCollapsing (#329) #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Sep 30, 2026
+10 −2
Merged

fix(agda): resolve the two unsolved metas in EchoHaplotypeCollapsing (#329) #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions proofs/agda/EchoHaplotypeCollapsing.agda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,21 @@ clone-count-aggregation G = aggregation-as-fold G
example-clones : List Clone
example-clones = clone₁ ∷ clone₂ ∷ []

example-count : aggregate-values countAggregator example-clones ≡ 2
example-count : aggregate-values {K = Haplotype} countAggregator example-clones ≡ 2
example-count = refl

-- Count clones per haplotype via monoid fold (the GROUP BY analogue).
-- In production: groupByKey + fold, not filter + length, to stay O(n).
--
-- `K` (the group-by key) is genuinely phantom in `GroupAggregator`/
-- `countAggregator` (issue #175's `agg` field never mentions it), so
-- nothing here forces Agda's unifier to solve it from `V`, `M`, or the
-- result type — it must be supplied. `Haplotype` is the key this
-- aggregator is used to group by in this module (the GROUP BY
-- analogue the comment above names), so it is also the semantically
-- honest choice, not just a syntactically convenient one.
count-clones-per-haplotype : List Clone → ℕ
count-clones-per-haplotype cs = aggregate-values countAggregator cs
count-clones-per-haplotype cs = aggregate-values {K = Haplotype} countAggregator cs

------------------------------------------------------------------------
-- 5. Choreographic framing: Raw ⊑ Collapsed
Expand Down
Loading