Repository navigation
fix(lifecycle): accept confirmed concurrent session cleanup - #149
Merged
Merged
Conversation
roodboi
marked this pull request as draft
October 6, 2026 14:57
roodboi
marked this pull request as ready for review
October 6, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft; scope corrected. This is independent concurrency hardening, not the cause of the reported native application shutdown refusal. The private test harness selected a different tmux server containing a same-name session with a different ownership token. Hack correctly refused that foreign session. Native shutdown qualification must use the application's verified supervisor context; it is not established by the first attempt with this build.
Concurrent foreground shutdown can separately remove an owned lifecycle session between listing it and reading its ownership token. Recheck the exact session only when the persisted backend/name/token match and the observed token is missing; accept explicit absence while preserving refusals for changed tokens, live or unknown sessions, missing query support, and backend errors.
The deterministic regression reproduces that interleaving with the actual owned-session retirement helper: it fails on the base and passes with this change. Validation: 47 focused lifecycle tests; full CLI suite 2,079 passed, 68 skipped, zero failures; typecheck, lint, privacy scan, compiled CLI build and version invocation passed. Unchanged database checks used the shared cache. Independent source review found no blocker. These source checks do not establish reproduction of this race in the real application.
Related: HACK-1216. Native application shutdown acceptance and packaged prerelease qualification remain separate gates; this PR does not publish a release.