Repository navigation
[bot] Merge master/0a7b1417 into rel/dev - #1850
Merged
Merged
Conversation
An item's user_context reached the chat request only for agentic_general_question and the single-shot path; every other agentic kind asked its question bare, so a dataset item scoped to a dashboard or widget could not be evaluated anywhere else. ChatClient now takes a user_context that it sends as userContext on every message, and a per-call value still overrides it. Each run_agentic_* binds the item's context to its client rather than to the first message: gen-ai treats a message without a context as cleared, so the follow-up and clarification turns need it too. The dispatch forwards item.user_context to every kind, and each evaluate_agentic_* passes it to its runner, keeping gate last. agentic_conversation takes the context per turn. The item's context applies from the first turn; a turn that sets user_context replaces it from that turn on, null clears it, and a turn that omits the field keeps the current one, as the attached chip does in the UI. The simulated user's replies carry the turn's context, and a turn skipped for an unresolvable expectation still changes it. Tests cover the forwarding for every kind at each layer (dispatch, evaluator, client binding), with a check that the dispatch list matches AGENTIC_TEST_KINDS, plus the per-turn conversation semantics and the client default on the wire. The Langfuse loader now fails the dataset load on a user_context that is not an object, instead of skipping it: a skipped context asks the item bare, which fails for a reason unrelated to the item. The README documents user_context in the dataset format, including the per-turn semantics of agentic_conversation and the enableAiContextSetup flag. jira: QA-29627 risk: low
feat(gooddata-eval): relay user_context on every agentic kind
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1850 +/- ##
===========================================
+ Coverage 84.10% 84.12% +0.01%
===========================================
Files 333 333
Lines 23099 23117 +18
===========================================
+ Hits 19428 19447 +19
+ Misses 3671 3670 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 0a7b141 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/37453280090).