Repository navigation
Center and right align wrapped text with character and word spacing - #1811
Merged
Merged
Conversation
Center alignment used the wrapper's textWidth, which counts the spacing after the last word and the word spacing twice, so the line sat left of the middle. Right alignment measured the line without wordSpacing, so it ran past the right edge by wordSpacing for each gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, follow-up to #1806, which left center alignment alone.
On wrapped text,
align: 'center'used the wrapper'stextWidth, which counts the spacing after the last word and the word spacing a second time, so the line sat left of the middle.align: 'right'measured the line withoutwordSpacing, so it ran past the right edge bywordSpacingfor each gap. Margins ofdoc.text('Hello big world', 50, 50, { width: 400, align, ...spacing }), read from the glyph boxespdftotext -bboxreports:characterSpacing: 4wordSpacing: 5wordSpacing: 5With no spacing set the output is unchanged. Alignment with
horizontalScalingis off on master even without spacing (right-aligned text at 120% ends 80pt past the edge) and is not addressed here. The new tests fail on master and pass with the change.prettier --check,lintandnpm test(61 files, 530 tests) pass on Node 22; I did not run Node 20 or 24.Checklist:
Written with AI assistance (Claude); I have reviewed the change.