Conversation
Extensions can add columns, row actions, bulk actions and toolbar buttons through developers:table:<resource>:<slot>, and header buttons and menu items to the detail pages through developers:details:<resource>:<slot>. - api-keys, webhooks, events, logs and sockets move to Layout::Resource::Tabular; the test-mode controls use its header block - webhook, event, log and socket pages render header buttons from controller getters so registered ones merge in - events and logs passed a permission string to @searchDisabled, which is always truthy, so search was always disabled; it now checks the permission - stable ids on built-in items, query params include registered filters Requires @fleetbase/ember-core 0.3.25 and @fleetbase/ember-ui 0.4.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions can add columns, row actions, bulk actions and toolbar buttons to developer tables through
developers:table:<resource>:<slot>. They can add header buttons and menu items to the detail pages throughdevelopers:details:<resource>:<slot>.Resources:
api-key,webhook,event,log,socket.Changes
Layout::Resource::Tabular. The api-keys test-mode toggle and key picker use its<:header>block.BaseController.detailsActionButtons), so registered buttons merge in.ids on built-in items; index query params include registered filter params; registries declared inextension.js.@searchDisabled. A string is always truthy, so search was always disabled; it now uses(cannot …).Depends on
Merge only after both are published. Before merging, bump
@fleetbase/ember-coreto^0.3.25and@fleetbase/ember-uito^0.4.5, and refresh the lockfile. Until then this branch builds against the old APIs and will not run.Naming and API reference:
docs/resource-view-registries.mdin ember-core.Testing
Lint and template-lint pass for the changed files.
extension.jsstill fails lint on an unusedgetWidgetById, which is already the case on main. No tests were run locally. All five list pages changed layout, so give them a click-through.