Skip to content

fix: Preserve recoverable migration state - #228

Merged
nfebe merged 1 commit into
mainfrom
fix/migration-improvements
Sep 26, 2026
Merged

nfebe merged 1 commit into
mainfrom
fix/migration-improvements

Conversation

@nfebe

@nfebe nfebe commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Preserve usable migration archives when remote publication or cleanup fails. Migration checks now use each deployment's environment and actual container metadata.

@nfebe
nfebe force-pushed the fix/migration-improvements branch 2 times, most recently from 6ee5e7b to 6c2efcb Compare September 26, 2026 09:54
@sourceant

sourceant Bot commented Sep 26, 2026

Copy link
Copy Markdown

no_plan

@nfebe
nfebe force-pushed the fix/migration-improvements branch 2 times, most recently from ee11f17 to ed1951a Compare September 26, 2026 18:05
Migration backups retain usable local archives when publication or cleanup fails.

Migration validation and container discovery use the deployment environment and runtime identity.
@nfebe
nfebe force-pushed the fix/migration-improvements branch from ed1951a to 1826b6f Compare September 26, 2026 18:24

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@sourceant

sourceant Bot commented Sep 26, 2026

Copy link
Copy Markdown

Code Review Summary

Backups now record per-component, destination, and cleanup results, adding partial and local_only statuses that keep the local archive usable when remote publication or cleanup fails, plus a retry-publication endpoint to re-upload a retained archive. Container network and access checks now resolve deployments from inspected container metadata, and compose validation loads deployment .env files while cleanup ignores failed backup attempts.

🚀 Key Improvements

  • Partial and local-only backup statuses preserve the local archive when remote publication or cleanup fails (internal/backup).
  • Per-component, destination, and cleanup results capture individual failure detail (internal/backup/types.go).
  • Container network membership is read from the container's own metadata, matching names and IDs (internal/networks/manager.go).

@nfebe
nfebe merged commit 8c1338c into main Sep 26, 2026
6 checks passed
@nfebe
nfebe deleted the fix/migration-improvements branch September 26, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant