Repository navigation
Fix Carp croak locations for Moo eval wrappers - #1695
Merged
Merged
Conversation
Use the call-site package captured when generated methods are entered while Carp walks caller frames. This lets Carp recognize the user package boundary and report the location that invoked Moo-generated methods, without changing ordinary caller frame numbering. Add a Moo eval-wrapper regression test and a changelog entry. Generated with [OpenAI Codex](https://openai.com/codex) Co-Authored-By: OpenAI Codex <openai-codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carp::croakreports Moo eval-generated call sites.Fixes #1656.
Validation
prove src/test/resources/unit/carp_moo_eval_wrapper_location.ton system Perl: pass.t/croak-locations.t: 29/29 assertions on JVM and interpreter.nice -n 19 timeout 3600 make: pass.nice -n 19 make check-links: pass.