Repository navigation
fix(parser): accept phaser forward declarations after heredocs - #1690
Merged
Merged
Conversation
Route standalone phaser names followed by a semicolon through subroutine forward-declaration parsing, matching standard Perl and avoiding a strict-subs bareword error after heredoc terminators. Add focused regression coverage and changelog entry. Fixes #1411. Generated with [OpenAI Codex](https://openai.com/codex/) Co-Authored-By: OpenAI Codex <codex@openai.com>
Materialize a pending hash reference when reading one of its elements, matching Perl behavior for defined checks and allowing Test-Mockify's Error helper to render an empty hash instead of undef. Generated with [OpenAI Codex](https://openai.com/codex) Co-Authored-By: OpenAI Codex <openai-codex[bot]@users.noreply.github.com>
fglock
marked this pull request as ready for review
October 8, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
;as forward subroutine declarations, so a validEND;after a heredoc does not trigger a strict-subs bareword error.Validation
nice -n 19 make— passed.prove src/test/resources/unit/heredoc.twith system Perl 5.42.2 — 25 tests passed.timeout 180 ./jperl src/test/resources/unit/heredoc.t— 25 tests passed.timeout 180 ./jperl --interpreter src/test/resources/unit/heredoc.t— 25 tests passed.nice -n 19 make check-links— passed.