Repository navigation
Fix inherited generated class constructor parameters - #1689
Merged
Merged
Conversation
fglock
force-pushed
the
fix/inherited-class-constructor-dispatch-1638
branch
from
October 8, 2026 10:57
a9956d9 to
d25a2e0
Compare
Filter named arguments passed from a generated child constructor to its generated parent constructor, while retaining the child's arguments for its own fields. Preserve all arguments for custom parent constructors and track constructor metadata with runtime snapshots. Closes #1638 Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <158243242+chatgpt-codex@users.noreply.github.com>
Preserve blessed IO method lookup and report native socketpair readiness and peer connectivity. Include focused regression coverage before rebasing and completing validation. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <158243242+chatgpt-codex@users.noreply.github.com>
Use F_GETFL and F_SETFL for native descriptors in IO::Handle::blocking so socketpair writes correctly reach EAGAIN. Cover the descriptor flag and connected socket send path. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <158243242+chatgpt-codex@users.noreply.github.com>
Keep queued IO::Async call futures alive until worker dispatch completes, register the compatibility patch in CPAN bootstrap, and document the fix. The upstream t/42function.t queue-priority case failed before the patch and passes with it applied. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <158243242+chatgpt-codex@users.noreply.github.com>
fglock
force-pushed
the
fix/inherited-class-constructor-dispatch-1638
branch
from
October 8, 2026 11:22
d25a2e0 to
23e93dc
Compare
Route PerlOnJava's Windows sockets through its channel-aware blocking implementation and keep the native descriptor assertion platform-specific. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <158243242+chatgpt-codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix inherited field initialization when a child class uses a generated constructor. Generated parent constructors now receive only parameters declared by the parent and its ancestors, while child arguments remain available for child field initialization. Custom parent constructors continue to receive the full argument list.
Add permanent coverage for inherited generated constructors, parent and child field initialization, and rejection of unknown parameters.
Closes #1638
Verification
nice -n 19 make: passesnice -n 19 make check-links: passes