Repository navigation
fix: route sibling RFP links correctly - #46
Closed
arunimshukla wants to merge 1 commit into
Closed
arunimshukla wants to merge 1 commit into
arunimshukla wants to merge 1 commit into
Conversation
arunimshukla
requested review from
cygnusv,
oskarth and
rymnc
as code owners
September 28, 2026 05:39
arunimshukla
force-pushed
the
fix/rfp-sibling-links
branch
from
September 28, 2026 18:28
f64471d to
bf9bedd
Compare
rymnc
pushed a commit
that referenced
this pull request
Oct 5, 2026
Cherry-picks #46 (sibling RFP links), #47 (continuation-line glossary definitions), and #48 (Custom UTXO link to Shielding), preserving @arunimshukla as commit author. Clean picks onto main; tests pass (62/62). Prompted by: ac --------- Co-authored-by: Arunim Shukla <54760103+arunimshukla@users.noreply.github.com>
Member
|
thank you @arunimshukla, merged in 3330621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed bare sibling links between RFP pages resolving to
/use-cases/...instead of/rfps/....RFP source files use valid same-directory links such as
rfp-trust-assurance.md. Because RFPs are intentionally outside the graph and the bare filename has no directory component, the renderer previously fell through to the first empty-prefix content type and produced a use-case route.The change:
rfp-*.mdlinks before graph candidate matching/rfps/<slug>/pagesValidation
I reproduced the incorrect routing for the four affected RFP targets and verified the fix against all seven current sibling-link occurrences in the map content.
Regression coverage includes:
The branch is a single commit and changes only
src/lib/render.tsandtests/render-links.test.ts.