Repository navigation
feat(docs)!: require Astro 7 and run the plugins on a unified processor - #192
Merged
Merged
Conversation
Astro 7's default Markdown processor, Sätteri, runs no remark or rehype plugins, so links lost `base` and prose lost its styling. The integration now puts its plugins on the site's `unified` processor, or a new one, and MDX reuses it. Peers move to astro 7, @astrojs/mdx 8 and @astrojs/react 7, and the demo site moves with them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
@eqtylab/docsto Astro 7 and releases it as 0.11.0. guardian's docs site needs it: Astro 6 carries a Critical advisory (GHSA-26w7-cxv4-gfx2, remote code execution through AVIF optimization) that is fixed only in astro 7.2.8, and guardian's security scans fail on it.Breaking
astro ^7.2.10,@astrojs/mdx ^8and@astrojs/react ^7.@astrojs/mdx8 needs astro 7.2.10, and supporting Astro 6 as well would mean two markdown code pathsWhy the integration changes
Astro 7's default Markdown processor, Sätteri, runs no remark or rehype plugins and only logs a warning. Left as it was, the integration's plugins would stop running: links would lose
base, and prose would lose its styling.The integration now adds its plugins to a
unifiedprocessor from@astrojs/markdown-remark:markdown.remarkPlugins) is extended, not replaced, so the site's own plugins keep running. guardian's site relies on this for itsremarkStripLeadingH1@astrojs/mdx8 reusesmarkdown.processorthroughextendMarkdownConfig, so.mdxpages get the same plugins.gfmandsmartypantsmove onto the processor, since the top-level settings are deprecated.Verification
pnpm lint,pnpm format:check,pnpm buildandpnpm testpassmain(Astro 6) and on this branch: all 2,390 pages differ only in entity encoding, whitespace between tags and minified CSS. The visible content and the plugins' output are unchangedWorth knowing
-webkit-backdrop-filter, so dialog backdrops lose their blur in Safari before 18After merge
Publish with
pnpm releasefrompackages/docs. Only@eqtylab/uipublishes automatically.🤖 Generated with Claude Code