Repository navigation
sdk: Add REQUIRE_COUCHDB_INTEGRATION_TESTS to fail CouchDB tests - #653
Open
paul-gerber-svg wants to merge 1 commit into
Open
paul-gerber-svg wants to merge 1 commit into
paul-gerber-svg wants to merge 1 commit into
Conversation
zrgt
self-requested a review
October 6, 2026 13:22
zrgt
requested changes
Oct 7, 2026
zrgt
left a comment
Contributor
There was a problem hiding this comment.
- Since #639 is merged, this now conflicts in
test/_helper/test_helpers.pyand in the unittest step ofpr.yml. Please rebase ontodevelopand keep both flags (REQUIRE_SCHEMA_TESTSandREQUIRE_COUCHDB_INTEGRATION_TESTS). Ideally both should share one small helper to parse the env var instead of duplicating.lower() in {"1", "true", "yes"}. test/examples/test_tutorials.pyalso usesskipUnless(COUCHDB_OKAY)for the CouchDB tutorial test, so it can still skip silently in CI. Could you cover it with the same flag?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CouchDB tests in
test/backend/test_couchdb.pyare skipped wheneverno CouchDB is reachable. In CI, the
sdk-testjob always starts aCouchDB service container, so a broken setup there just skipped the
tests instead of failing the build.
This adds a
REQUIRE_COUCHDB_INTEGRATION_TESTSenvironment variable,same idea as
REQUIRE_SERVER_INTEGRATION_TESTSfor the server'sDocker integration tests: set it to fail instead of skip when no
CouchDB is reachable. CI now sets it for the
sdk-testjob.Also fixes the
setup_testdb.pydocstring, which said CI passes--failsafeto avoid failing on an unreachable CouchDB, which was false.