Repository navigation
'DictDescriptorStore' add no-op commit - #642
Merged
s-heppner merged 1 commit intoOct 6, 2026
Merged
Conversation
Previously as `commit()` was not implemented the `DictDescriptorStore` raised errors and HTTP 500 caused by that. This change converts it to a silent no-op, as done in other non-persistent Store types.
zrgt
approved these changes
Sep 25, 2026
Contributor
|
If we merge this PR after #627, please revisit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously as
commit()was not implemented theDictDescriptorStoreraised errors and HTTP 500 caused by that.This change converts it to a silent no-op, as done in other non-persistent Store types.
Fixes #626