test(tui): fix startup resize race in hidden-frame tests - #4474
Merged
Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
gtardif
approved these changes
Sep 25, 2026
aheritier
added
area/tui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The harness's first
View()call was closing the readiness gate before Bubble Tea had a chance to asynchronously deliver the startupWindowSizeMsg. When that resize arrives afterwards, it legitimately clearsviewCacheInitializedand recomposes the hidden stream, which raced with the assertions inTestActualProgramHiddenHoverPreservesFollowTail/streaming_before_hoverand made the test flaky under load, as seen in https://github.com/docker/docker-agent/actions/runs/36150190157/job/108121238487?pr=4472.This change makes the test harness wait for the first
View()call after the startup window-size message has been processed before signaling readiness, so the recomposition happens deterministically during setup rather than racing with the test body. It's a test-only fix: no production code changes and no added sleeps.Verified with
task build,task test, andtask lint, plus targeted repeats of the readiness, hidden-hover, hidden-resize, and hidden-stream-write tests (50x, and 20x with-race -shuffle=on). A Windows build of./pkg/tuiwas compiled withGOOS=windows GOARCH=amd64to check portability, though it wasn't run on native Windows.