Repository navigation
fix(react): preserve manual date validity and Korean display - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual invalid or incomplete date input could be repaired on blur/Enter, and queued Ark synchronization frames could overwrite a newer draft. Give the DDS native text input one controlled owner while reusing the finished Ark calendar, trigger and portal. Preserve invalid/partial text and native validity; expose canonical ISO dates through onChange and an optional onValidityChange callback whose value is null when invalid. Korean display uses YYYY/MM/DD; storage/API remains YYYY-MM-DD.
Calendar selection returns focus to the input with a cancellable lifecycle frame. Existing label/error associations, readOnly/disabled behavior, date-only bounds and controlled reset/echo behavior are preserved.
Validation: 51 related React DOM assertions, corrected Seoul/UTC/Los_Angeles cases, React typecheck/build, and fresh packed consumers on React 19.3.0 and 18.3.1 passed. The packed gate verifies public DatePicker types, browser-free Node/worker SSR, strict control/outside DOM identity with expected Ark portal promotion/disposal, and valid/invalid native jsdom input. Existing CI runs unchanged.
Includes a patch Changeset under the existing fixed release group. Consumer Save handlers must guard validity.valid and validity.value; production Admin/Contract HTTP protection remains consumer integration work.