AGENTS.md: lint the whole repo, as CI does - #551
Merged
Merged
Conversation
The Commands block gave `uv run ruff check nameparser/`, but CI's "Run linter" step runs `uv run ruff check` over the whole repo, tests and tools included. Following the doc missed a ruff F402 in a test module that failed all five build jobs on #550. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 45 45
Lines 3812 3812
=======================================
Hits 3767 3767
Misses 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md's Commands block gave
uv run ruff check nameparser/as the lint command. CI's "Run linter" step (.github/workflows/python-package.yml) runsuv run ruff checkover the whole repo, tests and tools included. Following the doc missed a ruff F402 intests/v2/test_properties.py(a loop variable shadowing an import), which failed all five build jobs on #550 at the lint step.One line: the command now matches CI, with a note saying why.
Verified:
uv run ruff checkpasses on master (81cd6f7).🤖 Generated with Claude Code