Repository navigation
fix(heading): keep table_info in set_primary_key so a later rename quotes for the backend - #1643
Open
mayuriphad wants to merge 1 commit into
Open
mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
…otes for the backend Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1638
Heading.set_primary_keybuilt the new heading withouttable_info, so it lost the connection. When a projection then renamed an attribute of that heading,Heading.selecthad no adapter and fell back to backtick quoting. That is why(dj.U("b") & T).proj(c="b")compiled toSELECT DISTINCT `b` as "c"and failed on PostgreSQL. MySQL accepts backticks, so it hid the problem there.set_primary_keynow passestable_info=self.table_info, the same wayselectalready hands it on to the heading it builds.The new unit test in
tests/unit/test_pk_rules.pygives a heading a PostgreSQL adapter, callsset_primary_key, then renames an attribute. On master the expression comes out as`b`. With the fix it is"b".tests/unitpasses locally (458 passed). I did not run the integration suite because there is no Docker on this machine for the testcontainers.