Repository navigation
fix(metadata): accept null and empty primary-key namespace - #537
Merged
Merged
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
vuanhphung
added
the
integration-test
|
Node.js integration tests triggered. View workflow runs. The result posts back here as the "Node.js Integration Tests" check. |
|
Node.js integration tests triggered. View workflow runs. The result posts back here as the "Node.js Integration Tests" check. |
vikrantpuppala
approved these changes
Oct 6, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the public
PrimaryKeysRequestcontract unchanged (catalogName?: string,schemaName: string). Forward runtime null/undefined and explicit empty namespace strings to the kernel unchanged, matching Thrift. The Thrift implementation is unchanged.Pin
KERNEL_REVto4278294a0392cf138c170b071b855b03e29efe79, the merged databricks/databricks-sql-kernel#379 fix, and regenerate the native binding contract. Remains draft until native kernel packages containing the fix are published and the package pins/lockfile are updated; the currently published1.1.0predates the fix.Verified: 1,350 unit tests, production TypeScript build, lint, and tracked-source formatting passed. The rebuilt native binding passed all 16 namespace combinations against a localhost mock, plus table validation and lookup-error propagation. Full-project
tsc --noEmitstill reports existing self-import resolution errors in the token-federation examples.