Print negative integer constants as (- n) in SMT-LIB2 - #314
Merged
Merged
Conversation
SMT-LIB2 has no negative numerals, so -7 is rejected by solvers running in standard-compliant mode. Print negative Term::Int values and negative datatype discriminants as (- n). Fixes #307 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E3F27ojeP8M3P9NeHVQHsG
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E3F27ojeP8M3P9NeHVQHsG
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E3F27ojeP8M3P9NeHVQHsG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307
SMT-LIB2 has no negative numerals, so
-7is rejected by solvers in standard-compliant mode (e.g.z3 smtlib2_compliant=true). Negative values are now printed as(- 7)by a smallIntConstwrapper, used for bothTerm::Intand the discriminants indatatype_discr<..>.No test is added: default z3 accepts both spellings, so a UI test would pass before and after the change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01E3F27ojeP8M3P9NeHVQHsG
Generated by Claude Code